Skip to content

Add a workaround for #20379 by making RenderStartup single-threaded. #20380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add a workaround for #20379 by making RenderStartup single-threaded. #20380

wants to merge 1 commit into from

Conversation

andriyDev
Copy link
Contributor

Objective

Solution

  • Make RenderStartup single-threaded. This means we lose parallelism for RenderStartup, but the 0.16 behavior was already singlethreaded anyway - we don't lose anything, we just don't gain anything.

Testing

@andriyDev andriyDev requested review from IceSentry and atlv24 August 2, 2025 07:46
@andriyDev andriyDev added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 2, 2025
@andriyDev andriyDev added this to the 0.17 milestone Aug 2, 2025
@atlv24
Copy link
Contributor

atlv24 commented Aug 2, 2025

This wont be necessary if we get a patch release of gfx-rs/wgpu#8043

IceSentry
IceSentry approved these changes Aug 2, 2025
View reviewed changes
Copy link
Contributor

@IceSentry IceSentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve it in case we don't get the wgpu fix but it would be much nicer if we can get the fix and don't need this change.

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it S-Nominated-To-Close A triage team member thinks this PR or issue should be closed out. and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Aug 11, 2025
@alice-i-cecile
Copy link
Member

alice-i-cecile commented Aug 11, 2025 •
edited
Loading

It looks like that PR has been merged, and IIRC we've been promised a point release. Can we close this now?

EDIT: We can, wgpu 26.04 is out.

@andriyDev andriyDev deleted the workaround-heap branch August 11, 2025 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@IceSentry IceSentry IceSentry approved these changes

@atlv24 atlv24 atlv24 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Nominated-To-Close A triage team member thinks this PR or issue should be closed out.
Projects
Rendering
Status: Done
Milestone
0.17
Development

Successfully merging this pull request may close these issues.
4 participants
@andriyDev @atlv24 @alice-i-cecile @IceSentry